chore: DC evidence convention, hot-path indexes, filesystem module split #64

Merged
jesse merged 3 commits from chore/dc-evidence-convention-260428 into main 2026-05-04 22:33:35 +02:00
Owner

Summary

  • DC-1/2/4/5 + DG-01a: evidence convention, xtask evidence-collect and evidence-verify commands, CI job map generator, templates
  • Migration 018: composite indexes on thoughts(session_id, created_at) and memory_items scope/status columns for hot retrieval paths
  • Split registration/filesystem.rs (777 lines) into filesystem/ directory module (mod.rs, path.rs, unix_io.rs)
  • Harden session_id and role parameter validation in thought registration (typed errors instead of silent fallbacks)
  • Expand multi-transport integration tests with SSE event parsing helpers and additional transport coverage

Test Plan

  • cargo test --workspace
  • cargo clippy -- -D warnings
  • Migration 018 applied cleanly via schema_migration integration test
  • cargo run -p xtask -- evidence-verify tree passes on collected evidence

Self-Review Checklist

  • No hardcoded secrets
  • No unwrap() in library code
  • No println!/dbg!
  • Fail-open degradation preserved
  • Tests cover happy path and error cases
## Summary - DC-1/2/4/5 + DG-01a: evidence convention, xtask `evidence-collect` and `evidence-verify` commands, CI job map generator, templates - Migration 018: composite indexes on `thoughts(session_id, created_at)` and `memory_items` scope/status columns for hot retrieval paths - Split `registration/filesystem.rs` (777 lines) into `filesystem/` directory module (`mod.rs`, `path.rs`, `unix_io.rs`) - Harden `session_id` and `role` parameter validation in thought registration (typed errors instead of silent fallbacks) - Expand multi-transport integration tests with SSE event parsing helpers and additional transport coverage ## Test Plan - [ ] `cargo test --workspace` - [ ] `cargo clippy -- -D warnings` - [ ] Migration 018 applied cleanly via `schema_migration` integration test - [ ] `cargo run -p xtask -- evidence-verify tree` passes on collected evidence ## Self-Review Checklist - [x] No hardcoded secrets - [x] No `unwrap()` in library code - [x] No `println!`/`dbg!` - [x] Fail-open degradation preserved - [x] Tests cover happy path and error cases
Implements Phase A+B of the 260428 deliverable-checklist improvement plan:

- DC-5: delta-eval cadence templates (notes/templates/00-delta.md,
  PROJECTION.md, criterion-source-map.toml), planned-rows.toml
  for D-07, and docs/EVALUATION_CADENCE.md.
- DC-DG-01a: pre-stamp notes/evaluation-260428/evidence/PROJECTION.md
  skeleton with slip-clock fields, required-PR list, and OPEN-row
  classification. CLOSURE_SHA.txt deliberately not created (DC-DG-01b).
- DC-1: notes/evaluation-260428/evidence/{ci-runs,perf,build,raw}/
  with README codifying the <criterion-id>-<short-name>.<ext> naming
  pattern and manual-capture fallback.
- DC-2: xtask evidence-collect and evidence-verify {tree,map}
  subcommands. Forgejo + GitHub fetchers via ~/.netrc, perf + build
  capturers, atomic --force via temp directory, MANIFEST.json schema,
  full exit-code contract (0/1/2/3/4/5/64). 142 unit tests pass.
- DC-4 (elected): xtask gen-ci-job-map emits the section 6.3 gate
  to workflow job table. evidence/ci-job-map.md populated.
- Updated xtask/README.md and CLAUDE.md with the four new commands
  and exit-code tables.

Phase C (DC-DG-01b / DC-3 / DC-6) remains blocked on plan-02 B-1..B-4,
plan-03 QSD-1, plan-05 FM-1 trains or the slip clock firing.

Verified:
- cargo build -p xtask
- cargo test -p xtask  (142 passed)
- cargo clippy -p xtask --all-targets -- -D warnings
- cargo fmt --check
- evidence-verify map exits 0 on the carry-over ledger + planned rows
- gen-ci-job-map produces a non-empty table covering all 12 gates
feat: hot-path indexes, filesystem module split, input validation
Some checks failed
CI / Detect Changes (pull_request) Successful in 11s
CI / Integration Tests (pull_request) Has been skipped
CI / Benchmarks (pull_request) Has been skipped
CI / Security Scan (pull_request) Successful in 17s
CI / Format (pull_request) Successful in 20s
CI / Check file lengths (pull_request) Successful in 29s
CI / Conventional Validation (pull_request) Successful in 49s
CI / Clean Build Sample 2 (pull_request) Has been skipped
CI / Clean Build Sample 1 (pull_request) Has been skipped
CI / Clean Build Sample 3 (pull_request) Has been skipped
CI / Clean Build Summary (pull_request) Has been skipped
CI / Documentation (pull_request) Successful in 1m59s
CI / Clippy (pull_request) Successful in 2m26s
CI / Check (linux-aarch64 compile-validation) (pull_request) Successful in 2m32s
CI / Test (pull_request) Successful in 6m4s
CI / Coverage (80% gate) (pull_request) Successful in 7m3s
CI / Deny (pull_request) Failing after 10m6s
CI / Audit (CVEs) (pull_request) Failing after 10m8s
CI / D-02 Clean Build Gate (pull_request) Failing after 14m12s
CI / RSS gate (P-15) (pull_request) Successful in 13m0s
CI / Build (release) (pull_request) Successful in 14m32s
CI / PR Size Check (pull_request) Successful in 10s
CI / CI Report (pull_request) Successful in 5s
1d326f9cff
- Migration 018: composite indexes on thoughts and memory_items for hot retrieval
- Split registration/filesystem.rs into filesystem/ directory module
- Harden session_id and role param validation with typed errors
- Expand multi-transport integration tests with SSE helpers
fix: allow webpki-roots duplicate
All checks were successful
CI / Detect Changes (pull_request) Successful in 9s
CI / Benchmarks (pull_request) Has been skipped
CI / Integration Tests (pull_request) Has been skipped
CI / Format (pull_request) Successful in 20s
CI / Security Scan (pull_request) Successful in 27s
CI / Check file lengths (pull_request) Successful in 31s
CI / Conventional Validation (pull_request) Successful in 56s
CI / Clean Build Sample 1 (pull_request) Has been skipped
CI / Clean Build Sample 3 (pull_request) Has been skipped
CI / Clean Build Sample 2 (pull_request) Has been skipped
CI / Clean Build Summary (pull_request) Has been skipped
CI / Documentation (pull_request) Successful in 2m11s
CI / Check (linux-aarch64 compile-validation) (pull_request) Successful in 2m27s
CI / Clippy (pull_request) Successful in 2m29s
CI / D-02 Clean Build Gate (pull_request) Successful in 4m11s
CI / Deny (pull_request) Successful in 5m30s
CI / Audit (CVEs) (pull_request) Successful in 5m41s
CI / Test (pull_request) Successful in 6m41s
CI / Coverage (80% gate) (pull_request) Successful in 7m27s
CI / RSS gate (P-15) (pull_request) Successful in 5m22s
CI / Build (release) (pull_request) Successful in 6m43s
CI / PR Size Check (pull_request) Successful in 10s
CI / CI Report (pull_request) Successful in 4s
d6b0463198
jesse merged commit 95f3d44170 into main 2026-05-04 22:33:35 +02:00
jesse deleted branch chore/dc-evidence-convention-260428 2026-05-04 22:33:35 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jesse/cognix!64
No description provided.